Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt plugin update #1971

Merged
merged 2 commits into from
May 14, 2020
Merged

sbt plugin update #1971

merged 2 commits into from
May 14, 2020

Conversation

poslegm
Copy link
Collaborator

@poslegm poslegm commented May 14, 2020

No description provided.

@poslegm poslegm requested a review from kitbellew May 14, 2020 15:07
@@ -118,7 +118,7 @@ in the `.scalafmt.conf` configuration file and downloaded dynamically.

```scala
// In project/plugins.sbt. Note, does not support sbt 0.13, only sbt 1.x.
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.3.2") // "2.3.2" is just sbt plugin version
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.0") // "2.4.0" is just sbt plugin version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: can mdoc variable injection be used somehow, both here and in plugins.sbt?

https://scalameta.org/mdoc/docs/why.html#variable-injection

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but we'll still need to keep this variable up to date manually. @STABLE_VERSION@ comes from git tag, but plugin version managed by other repository

@poslegm poslegm merged commit 16b53a6 into scalameta:master May 14, 2020
@poslegm poslegm deleted the sbt-plugin-update branch May 14, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants