Split: represent a newline alternative differently #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `split` parameter conflicts with the class field of the same name, so rename to nextSplit. Also, for consistency, rename all variables to use nextXxx; currently, some as nextXxx and some are newYyy.
Currently, newlines can be optionally replaced with a space or nosplit. However, the problem is that the replacement should not come with the same set of indents (or, rather, add a shorter negative indent). Also, move handling of the replacement into State, from FormatWriter.
poslegm
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, newlines can be optionally replaced with a space or nosplit. However, the problem is that the replacement should not come with the same set of indents (or, rather, add a shorter negative indent).
Also, move handling of the replacement into State, from FormatWriter.
Fixes #1400.