Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf-java, protobuf-java-util to 3.24.4 #418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scala-steward
Copy link
Contributor

About this PR

πŸ“¦ Updates

from 3.21.12 to 3.24.4

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.google.protobuf" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.protobuf" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@xuwei-k
Copy link
Contributor

xuwei-k commented Oct 19, 2023

[info] Value
[info] - should be serialized the same as in Java (and parsed back to original) *** FAILED ***
[info]   java.lang.IllegalArgumentException: google.protobuf.Value cannot encode double values for infinity or nan, because they would be parsed as a string.
[info]   at com.google.protobuf.util.JsonFormat$PrinterImpl.printValue(JsonFormat.java:972)
[info]   at com.google.protobuf.util.JsonFormat$PrinterImpl.access$1600(JsonFormat.java:708)
[info]   at com.google.protobuf.util.JsonFormat$PrinterImpl$7.print(JsonFormat.java:843)
[info]   at com.google.protobuf.util.JsonFormat$PrinterImpl.print(JsonFormat.java:760)
[info]   at com.google.protobuf.util.JsonFormat$Printer.appendTo(JsonFormat.java:367)
[info]   at com.google.protobuf.util.JsonFormat$Printer.print(JsonFormat.java:377)
[info]   at scalapb.json4s.JavaAssertions.assertJsonIsSameAsJava(JavaAssertions.scala:65)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants