Find transaction in transaction group by id #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change `txn GroupIndex` can inappropriately return `-1` despite all fields of `tx` are the same as all fields of `gtxns[x]`. Apparently, the reason is that either `tx` or `gtxns` can be overwritten at some point by the same content but stored in different memory location (`indexOf` uses `===` which compares objects *by reference*). I had this problem when providing liquidity twice in a row in Pact smart contract (https://github.com/pactfi/algorand-testbed/blob/master/constant_product.teal)
|
Oh, actually it doesn't work for contract-to-contract calls (or inner txs in general) because they don't have ids. Not sure if they should though |
|
We should definitely look based on tx id. However yes - we probably need more inspection into that. Thanks for the update! |
|
I've updated the PR by using |
|
it seams this breaks our tests. |
But |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change
txn GroupIndexcan inappropriately return-1despite all fields oftxbeing the same as all fields ofgtxns[x]. Apparently, the reason is that eithertxorgtxnscan be overwritten at some point by the same content but stored in a different memory location (indexOfuses===which compares objects by reference).I had this problem when providing liquidity twice in a row in Pact smart contract
This change looks pretty safe, but I don't know if the root cause (change of memory locations) should be found and eliminated in addition or instead of this commit.