Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a check to see if magnifying icon has already been added to icons… #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ianardavis
Copy link

… container

@ianardavis ianardavis closed this Apr 24, 2024
@ianardavis
Copy link
Author

Experienced issue when using plugin:

using not init on load
"<script>window.CI360 = { notInitOnLoad: true }</script>" in html.

add "images360.setAttribute( 'data-amount-x', imageList.length );" in JS file

initialising and adding hotspots
window.CI360.init();
window.CI360.addHotspots( 'images360', HOTSPOTS_CONFIG );

No errors occur in window, but two magnifying icons are present. this PR adds a check in the addMagnifying function to check there is not already an icon present before adding a new one.

@ianardavis ianardavis reopened this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant