feat: initial code release #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclimse
force-pushed
the
feat/setup-code
branch
from
f8f0b63
to
3c1d5a5
Compare
cyclimse
commented
Feb 28, 2023
cyclimse
commented
Feb 28, 2023
cyclimse
force-pushed
the
feat/setup-code
branch
from
bd47d1c
to
c58df9c
Compare
cyclimse
commented
Mar 1, 2023
Shillaker
previously approved these changes
Mar 1, 2023
thomas-tacquet
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the code that I transferred over from the private repository.
Modifications made (in accordance to spec discussed with Thomas):
Renamed package to
scaleway_functions_pythonMoved hints from
scaleway_functions_python.hintsto ``scaleway_functions_python.v1.hints`No longer catch exceptions (unlike our subRT)
Run the server in debug mode by default (otherwise the exception / stack trace will be absorbed by Flask)
Renamed server.py to serving.py
Went from a
src/layout to a flat layout. Otherwise, the only way to make it work is to nest it into an additional package.