Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enabledInspections setting #143

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

gsrajesh89
Copy link
Contributor

@gsrajesh89 gsrajesh89 commented Sep 16, 2022

Currently we have disabledInspections setting to disable the inspections.
To support incremental enable of rules we can use the enabledInspections setting to enable certain set of rules.
disabledInspections takes precedence over enabledInspections

@gsrajesh89 gsrajesh89 changed the title Add enabledInspections setting Draft: Add enabledInspections setting Sep 16, 2022
@gsrajesh89 gsrajesh89 changed the title Draft: Add enabledInspections setting Add enabledInspections setting Sep 19, 2022
@ches
Copy link
Contributor

ches commented Oct 31, 2022

Hi @mccartney, do you have the access rights (and time) for maintaining the sbt plugin?

This looks like a straightforward change to expose configurability that already exists as a command line flag.

(Perhaps we could define GitHub teams in the org like @scapegoat-scala/gradle-maintainers and put them in CODEOWNERS files in the repos, to help contributors know who can review PRs).

@mccartney
Copy link
Collaborator

@ches Thanks for tagging me.

To be honest I lack knowledge and experience with sbt. I simply don't use it (except for some open source projects like scapegoat). I haven't used sbt-scapegoat anywhere, thus I lack the focus.

As to permissions - I think I have permissions to (review and) merge the change. But I don't think I have permissions to publish a new version.

As to defining CODEOWNERS - that's a good idea. It doesn't necessarily have to be the same set of people for each of the subprojects.

@sksamuel can decide.

Copy link
Collaborator

@mccartney mccartney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said, the code looks fine to me. Thank you for your contribution. Merging it.

@mccartney mccartney merged commit 1c5f694 into scapegoat-scala:master Oct 31, 2022
@chameleon82
Copy link

@sksamuel could you help to release new version with those changes?

@Johnnei
Copy link
Collaborator

Johnnei commented Feb 2, 2023

@mccartney @sksamuel We are still heavily using sbt as our built tool, so it would be great if we could sort out the publishing rights. We still have a few more enhancements/bug-fixes in the pipeline based on our rollout to a few hundred projects.
I'm also happy to help maintaining the plugin to give a bit more knowledge on sbt (although I'm not super confident there myself as well).

@mccartney
Copy link
Collaborator

Ack. As mentioned above, I never had the publishing rights here. I think it's @sksamuel who has them. And can decide on maintenance of the plugin. I very much like your offer and support it.

@sksamuel
Copy link
Collaborator

sksamuel commented Feb 4, 2023

@Johnnei @mccartney you both want admin rights on this repo, then you could publish etc ?

@Johnnei
Copy link
Collaborator

Johnnei commented Feb 6, 2023

@Johnnei @mccartney you both want admin rights on this repo, then you could publish etc ?

I think that would be great to get updates going again. As I'm still new to contributing to scapegoat eco granting it only to @mccartney might be a bit more trustworthy as he publishes for scapegoat itself as well. I'll leave that call up to you of course :)

@sksamuel
Copy link
Collaborator

sksamuel commented Feb 8, 2023

@Johnnei is invited as a collaborator. @mccartney you are now an admin.

@Johnnei Johnnei added this to the 1.2.0 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants