-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enabledInspections setting #143
Add enabledInspections setting #143
Conversation
Hi @mccartney, do you have the access rights (and time) for maintaining the sbt plugin? This looks like a straightforward change to expose configurability that already exists as a command line flag. (Perhaps we could define GitHub teams in the org like |
@ches Thanks for tagging me. To be honest I lack knowledge and experience with sbt. I simply don't use it (except for some open source projects like scapegoat). I haven't used sbt-scapegoat anywhere, thus I lack the focus. As to permissions - I think I have permissions to (review and) merge the change. But I don't think I have permissions to publish a new version. As to defining @sksamuel can decide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having said, the code looks fine to me. Thank you for your contribution. Merging it.
@sksamuel could you help to release new version with those changes? |
@mccartney @sksamuel We are still heavily using sbt as our built tool, so it would be great if we could sort out the publishing rights. We still have a few more enhancements/bug-fixes in the pipeline based on our rollout to a few hundred projects. |
Ack. As mentioned above, I never had the publishing rights here. I think it's @sksamuel who has them. And can decide on maintenance of the plugin. I very much like your offer and support it. |
@Johnnei @mccartney you both want admin rights on this repo, then you could publish etc ? |
I think that would be great to get updates going again. As I'm still new to contributing to scapegoat eco granting it only to @mccartney might be a bit more trustworthy as he publishes for scapegoat itself as well. I'll leave that call up to you of course :) |
@Johnnei is invited as a collaborator. @mccartney you are now an admin. |
Currently we have
disabledInspections
setting to disable the inspections.To support incremental enable of rules we can use the enabledInspections setting to enable certain set of rules.
disabledInspections
takes precedence overenabledInspections