Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in netinterfaces.cpp #187

Closed
jchen-dawnscene opened this issue Mar 25, 2023 · 1 comment
Closed

Bug in netinterfaces.cpp #187

jchen-dawnscene opened this issue Mar 25, 2023 · 1 comment

Comments

@jchen-dawnscene
Copy link
Contributor

liblsl/src/netinterfaces.cpp
Lines 89-91

		LOG_F(INFO, "netif '%s' (status: %d, multicast: %d, broadcast: %d)", addr->ifa_name,
			addr->ifa_flags & IFF_MULTICAST, addr->ifa_flags & IFF_UP,
			addr->ifa_flags & IFF_BROADCAST);

I guess it should be:

		LOG_F(INFO, "netif '%s' (status: %d, multicast: %d, broadcast: %d)", addr->ifa_name,
			addr->ifa_flags & IFF_UP, addr->ifa_flags & IFF_MULTICAST, 
			addr->ifa_flags & IFF_BROADCAST);
@tstenner
Copy link
Collaborator

Of course. Could you open with the change so you get authorship credits?

jchen-dawnscene added a commit to dawnscene/liblsl that referenced this issue Mar 30, 2023
@jchen-dawnscene
Fixed bug sccn#187 in netinterfaces.cpp
5919374
tstenner pushed a commit that referenced this issue May 26, 2023
@jchen-dawnscene
Fix lsl_cpp.h exception handling (#194)
4501710 
* Fixed bug #187 in netinterfaces.cpp
* Fix lsl_cpp.h exception handling

For error code lsl_lost_error, check_error() shall throw lost_error rather than timeout_error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tstenner @jchen-dawnscene