Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] vulnerability found in package es5-ext [APP3 PR] #1143

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

ms-oh
Copy link
Contributor

@ms-oh ms-oh commented Mar 1, 2024

JIRA https://scheduleonce.atlassian.net/browse/ONCEHUB-78785

For code author

What does this PR do?

[fixed] vulnerability found in package es5-ext

Why do we want to do that?

[fixed] vulnerability found in package es5-ext

What are the high level changes?

upgrade package es5-next

What other information should the reviewer be aware of when looking at this code?

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@ms-oh ms-oh self-assigned this Mar 1, 2024
@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shivamke
You can assign the PR to them by writing /assign @shivamke in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@raghavaggarwalOH raghavaggarwalOH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update Change log as well

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shivamke
You can assign the PR to them by writing /assign @shivamke in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shivamke
You can assign the PR to them by writing /assign @shivamke in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ms-oh
Copy link
Contributor Author

ms-oh commented Mar 4, 2024

Update Change log as well

done @raghavaggarwalOH

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raghavaggarwalOH
To complete the pull request process, please assign shivamke
You can assign the PR to them by writing /assign @shivamke in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: raghavaggarwalOH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations oh-integrations merged commit 5a512c5 into qa Mar 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants