Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Peer dependencies issue related to React v18 #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Blaumaus
Copy link

This PR fixed the issue occurring in some environments while installing this package.

22:53:01.146 | npm ERR! Could not resolve dependency:
22:53:01.146 | npm ERR! peer react@"^16.8.1 \|\| ^17" from [email protected]
22:53:01.146 | npm ERR! node_modules/react-alert
22:53:01.146 | npm ERR!   react-alert@"^7.0.3" from the root project

@ddkang
Copy link

ddkang commented May 8, 2022

Any chance this could be merged?

@DavidChouinard
Copy link

@schiehll we're held up on this to upgrade our app, can we merge? 🙏

@Blaumaus
Copy link
Author

@DavidChouinard until this PR is merged you can try out it's fork with the React 18 support - https://www.npmjs.com/package/@blaumaus/react-alert

@DavidChouinard
Copy link

Fantastic thank you. @schiehll would still be great to have this merged to have an official supported distribution

@brightsider
Copy link

@schiehll merge it pls

@steeply
Copy link

steeply commented Nov 18, 2022

@schiehll when is the merge?

@danielnathaniel
Copy link

https://www.npmjs.com/package/@blaumaus/react-alert - this is not working and has the same issue as the original Node Package.

@akamom
Copy link

akamom commented Sep 7, 2023

poke

@oneil512
Copy link

Any reason this hasn't been merged yet?

@dhwang
Copy link

dhwang commented Jul 19, 2024

maybe @schiehll is no longer with us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants