Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvapich device is not contained in src/include/Rules.mk leading to undefined ESMF_FC #13

Closed
platipodium opened this issue Jun 5, 2022 · 4 comments
Assignees

Comments

@platipodium
Copy link
Member

In src/include/Rules.mk we consider openmpi, mpich2, mpich3 and intelmpi devices, but not yet mvapich2. This is available and can be tested on femto.

@platipodium
Copy link
Member Author

There is also a problem in the script with path splitting with -

/sciclone/home20/clemmen/devel/schism/schism-esmf% mpifort -compile_info | cut -d' ' -f1 | cut -d'-' -f1
/usr/local/intel

@platipodium
Copy link
Member Author

Fixed by commit e4a0d9b

@josephzhang8
Copy link
Member

josephzhang8 commented Jun 6, 2022 via email

@platipodium
Copy link
Member Author

Thx Carsten! I'll need to look at the schism_step(it) carefully after I go back from the conference. It'd not be a problem to make it INT8, which I think is integer(kind=8) in FORT? I'm surprised that this would crash the code..

Your comment is directed to #15. And there is no crash, as we limit the I8 datatype coming from ESMF to max out (and exit beyond) I4 limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants