Added DoctrineObjectConstructor

[guilhermeblanco]

Fixed #141

[stof]

you should typehint the interface instead (available in Doctrine Common)

[guilhermeblanco]

That was exactly what you wanted me to modify. Have I missed something?
It was the ManagerInterface and you requested to be the ManagerRegistry, so I modified it.
Which one do you prefer? Interface of this one?

[stof]

@guilhermeblanco you were using the BC (deprecated) RegistryInterface of the bridge. I wanted you to use the ManagerRegistry interface available in Doctrine Common, not the Symfony\Bridge\Doctrine\ManagerRegistry implementation of Doctrine\Common\Persistence\ManagerRegistry

[sgarner]

What is the correct way to enable this functionality in a Symfony app?

I was able to hack it on by editing line 154 of vendor/jms/serializer-bundle/JMS/SerializerBundle/Resources/config/services.xml to read:

<service id="jms_serializer.object_constructor" alias="jms_serializer.doctrine_object_constructor" public="false" />

Obviously, this is not the right way to do it.

Shouldn't there be a config parameter to say which constructor to use? Or am I misunderstanding something.

[j]

@sgarner, yep, seems to be an incomplete PR

[bartrail]

@sgarner what did you do to get it working? (in detail, how did you hack the config? ;) I have some missing references after persisting to doctrine too..

[sgarner]

@bartrail I just edited that line referenced in my previous comment. That's all.

Of course if you want that change to be deployable then you need to first create your own fork of JMSSerializerBundle in which to make the change, and then set your project to use your fork in composer.

When I have time I will look into making a patch to expose this functionality from config, if nobody else cares to do that before me :)

[bartrail]

@sgarner thanks, after reading the config twice, I got it ;) then I added this line to my servies.yml

jms_serializer.object_constructor:
    alias: jms_serializer.doctrine_object_constructor

which does basically the same (register the DoctrineObjectConstructor) by overloading the jms_serializer.object_constructor id - but unfortunately I don't get proper deserialized doctrine documents like in #305 (though I'm using json and not xml as described in the issue). Is there maybe another trick need to get this working (like here) ?