Fix RegisterEventListenersAndSubscribersPass & event_subscribers service accessibility #196
Conversation
| $container->getDefinition('jms_serializer.event_dispatcher') | ||
| ->addMethodCall('setListeners', array(call_user_func_array('array_merge', $listeners))); | ||
| foreach ($listeners as $listener) { | ||
| $evenDispatcherDefinition->addMethodCall('addListener', $listener); |
There was a problem hiding this comment.
Is there a reason you are not using the setListeners call anymore? I added it to avoid a single method call per listener.
There was a problem hiding this comment.
setListeners do not transform the value it receives.
in RegisterEventListenersAndSubscribersPass, $listeners look like this (ordered by priority):
array(
array($eventData['event'], array($id, $method), $class, $format),
)
Whereas EventDispatcher\LazyEventDispatcher::$listeners look like:
array(
'event' => array(
array(array('id', 'method'), 'type', 'format'),
array($callable, 'type', 'format'),
array(array('id', 'method'), 'type', 'format'),
),
)
I could also prepare the $listeners array to be set with setListeners, but i felt like it would duplicate some "logic" from the EventDispatcher class ...
There was a problem hiding this comment.
Could you add this conversion to the compiler pass, and then set the converted data using the setListeners method?
|
And for the public visibility, the compiler pass should check it IMO |
|
@stof Good point, added a commit about that |
Fix RegisterEventListenersAndSubscribersPass & event_subscribers service accessibility
No description provided.