Null handling #222
Closed
Null handling #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstructor. Add tests to BaseSerializationTest: * testNull when expecting types * testNumerics when expecting numeric types * testDateTime * testDeserializingNull when using InitializedObjectConstructor Add content for blog_post_unauthored and date_time: * JsonSerializationTest * xml/blog_post_unauthored.xml * xml/date_time.xml * yml/blog_post_unauthored.yml * yml/date_time.yml So, from the phpunit test results, we see: * fails when serializing a simple DateTime * error when deserialing a null when expecting a DateTime * error: no support for the "float" alias for "double" * error when deserializing: a null value will not overwrite a non-null property in the initialized object
* fix serialization/deserialization of DateTime * there's no change to parseDateTime() other than removing DOS carriage returns
| return $visitor->visitNull(null, $type); | ||
| } | ||
|
|
||
| return $visitor->visitString($date->format($this->getFormat($type)), $type); | ||
| } |
There was a problem hiding this comment.
Why writing exactly the same method 3 times ? you should keep the code DRY
There was a problem hiding this comment.
I agree and will refactor after @schmittjoh reviews it.
|
I've merged some commits of this PR (mostly tests), and refactored some other parts to use the changes I've made to master already. Everything passed now, let me know if there are any problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm resubmitting this patch, with commits separated for easier review.
(See individual commit for more info.)