-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] added support for PHPCR #340
Conversation
$previousId = $id; | ||
} | ||
} | ||
$registries = array(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the duplicate code here should be refactored
I have added a compiler pass to more reliably determine if ORM/PHPCR ODM is really available since both DoctrineBundle and DoctrinePHPCRBundle can be used without having the ORM/PHPCR ODM available |
return; | ||
} | ||
|
||
$registries = array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this entire code here looks ugly imho but I didn't come up with a nicer solution. then again I wonder if it would not be more readable by simply duplicating the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It often helps to split things up into smaller methods.
Is the $managerId
below necessary? Why not check for the registry directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did a few tweaks. code is now easier to read
@schmittjoh ok to merge? |
Will try to find some time this evening to review/merge some of the PRs On Thu, Nov 28, 2013 at 2:06 PM, Lukas Kahwe Smith <[email protected]
|
+1 would love to use this, currently doing manual encoding on PHPCR Documents. |
[WIP] added support for PHPCR
thx .. now its been 4 months since the last release of this bundle and seralizer. speaking of which .. any plans for 1.0? :) |
Yeah, but we should probably make the license switch before 1.0. |
lets do it http://licenses.beberlei.de :) |
Yep, it's on my TODO list :) |
alright .. but if is going to take longer then it might be good to do a new 0.x release of the bundle and the lib .. |
I don't hope so, but just so that you don't need to rely on dev versions, I've tagged new releases for both packages (bundle & library). |
thx |
this also improves the detection for when the ORM is actually enabled.
requires schmittjoh/serializer#184
adding MongoDB should be easy too