Serializer and stateful dependencies should be unshared

[lstrojny]

An invocation of Serializer::serialize() leads to "Can't pop from an empty datastructure" in SplStack if the serializer invocation leads to another serializer invocation on the same service down the road. In my case that happened when the serializer used doctrine to load an entity which logged a message on dev but there was logging functionality that uses the serializer.

This is the reproduction case:

class Foo
{
    /** @Serializer\Exclude() */
    public $serializer;
    /** @Serializer\Accessor(getter="get") */
    private $property;
    public function get() { return $this->serializer->serialize('foo', 'json'); }
}

$serializer = $container->get('jms_serializer');
$obj = new Foo();
$obj->serializer = $container->get('jms_serializer');

$serializer->serialize($obj, 'json');

To fix this, jms_serializer and its stateful dependencies may not be shared. This PR marks the following services as not shared:

• jms_serializer
• jms_serializer.json_serialization_visitor
• jms_serializer.xml_serialization_visitor
• jms_serializer.yaml_serialization_visitor
• jms_serializer.json_deserialization_visitor
• jms_serializer.xml_deserialization_visitor

[goetas]

hmm, this problems is the same of schmittjoh/serializer#341 but with a different solution.

I'm starting to see it as a common problem.

The solution you used might work only in some cases when used with symfony, but not in other situations.
The solution in #341 works better but is more complex.

Another approach I was thinking about, were "visitor factories" to inject into the serializer class.
That approach will generate new visitors on each serialization call...

[goetas]

This is solved in serializer 2.0 and will be released soon.