Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization handler registration by priority #657

Merged
merged 1 commit into from
May 25, 2018
Merged

Fix serialization handler registration by priority #657

merged 1 commit into from
May 25, 2018

Conversation

discordier
Copy link
Contributor

This fixes #656 by examining the priorities for each direction+type+format combination and not globally.

This now allows to register the same handler for multiple types and/or formats as it was possible in pre 2.4 versions.

This fixes #656 by examining the priorities for each
direction+type+format combination and not globally.
@discordier
Copy link
Contributor Author

Build failure related to travis outage, the PHP 5.6 build hang for more than 10 mins.

@goetas could you restart the build in travis please?

@goetas
Copy link
Collaborator

goetas commented May 23, 2018

@discordier this is an alternative implementation that solves the problem without a special case for subscribers and listeners and not concatenation.

(but I have included your tests)

As we are migrating the bundle to MIT, do you agree to license your changes under the MIT license?

@goetas goetas merged commit 5d2069e into schmittjoh:master May 25, 2018
@discordier discordier deleted the hotfix/issue-656 branch May 31, 2018 22:00
@discordier
Copy link
Contributor Author

I do, I guess I already denoted so in the license change issue.

@bpolaszek bpolaszek mentioned this pull request Jun 19, 2018
bpolaszek added a commit to bpolaszek/JMSSerializerBundle that referenced this pull request Jun 19, 2018
goetas added a commit that referenced this pull request Jun 19, 2018
@bpolaszek bpolaszek mentioned this pull request Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not register custom handler for multiple types since #645
2 participants