Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CONTRIBUTING.md and code fixing by phpcbf #840

Merged
merged 1 commit into from
Mar 7, 2021

Conversation

gam6itko
Copy link
Contributor

@gam6itko gam6itko commented Mar 6, 2021

Q A
Bug fix? no
New feature? no
Doc updated CONTRIBUTING.md
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

add CONTRIBUTING.md without Documentation section;
add doctrine/coding-standard to composer.json;
fix codebase with phpcs;

I just copied the files (CONTRIBUTING.md, .phpcs.xml.dist) from schmittjoh/serializer repository and ran the vendor/bin/phpcbf command.

Similar to #829

Hope this will help for further contributions

add `doctrine/coding-standard` to composer.json;
fix codebase with phpcs;
@gam6itko gam6itko changed the title CONTRIBUTING.md and code fixing by phpcs add CONTRIBUTING.md and code fixing by phpcs Mar 6, 2021
@gam6itko gam6itko changed the title add CONTRIBUTING.md and code fixing by phpcs add CONTRIBUTING.md and code fixing by phpcbf Mar 6, 2021
@goetas
Copy link
Collaborator

goetas commented Mar 7, 2021

thanks for your contribution

@goetas goetas merged commit 0501834 into schmittjoh:master Mar 7, 2021
@gam6itko gam6itko deleted the phpcs branch March 7, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants