Add Serializer::getMetadataFactory #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we add this to the builder instead? |
|
Hmm, the factory is instantiated in the build method, it'd be weird to store it in the builder, wouldn't it? |
|
Yeah, true. The proper solution would probably involve to create a builder for the metadata factory as you suggested in schmittjoh/metadata#31. Although I'm not super happy with this extension point, I'll merge it for now; it might be removed in future versions though. |
schmittjoh
added a commit
that referenced
this pull request
Jul 8, 2013
Add Serializer::getMetadataFactory
goetas
added a commit
that referenced
this pull request
May 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata factory can be injected into other services with the bundle. However, with the lib alone, there is no way to access the metadata factory. This solves that.