Typecast when serializing primitive types #15
Conversation
|
With the new type handling, I think this makes sense. Could you add some tests for this? |
| * @param string $primitiveType | ||
| * @param mixed $data | ||
| */ | ||
| public function testSerializationCastsType($primitiveType, $data) |
There was a problem hiding this comment.
Maybe I'm missing something, but this does not seem to actually test that the data was cast, no?
I think you need to add something like assertInternalType.
There was a problem hiding this comment.
Good point, it was really just testing that the correct visitXXX() function would be called. I have since moved the function into the JsonSerializationTest, as the function is in the abstract GenericSerializationVisitor, so we can only test it in one of the concrete classes.
One more thing. I noticed that one of the functions in there is called visitDouble() where the PHP internal type is actually called float. Should we rename the function (in a seperate PR of course). Or add a wrapper visitFloat() that just calls the other one?
- Removed the fairly useless test from GraphNavigator - Added them to JsonSerialization
Typecast when serializing primitive types
I have noticed that the serializer does not fully enforce primitive types. I am not sure whether that is desired or not.