Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XmlNamespace annotation documentation #213

Merged
merged 1 commit into from
Jan 13, 2014
Merged

Add XmlNamespace annotation documentation #213

merged 1 commit into from
Jan 13, 2014

Conversation

jeserkin
Copy link
Contributor

Added documentation for new feature @XmlNamespace as requested in this #58 (comment) pool request

@ajgarlag
Copy link
Contributor

You should document namespace option in the XmlElement annotation

@ajgarlag
Copy link
Contributor

The xml_reference.rst and yml_reference.rst files should include the new options too.

@jeserkin
Copy link
Contributor Author

Not sure how to specify colon in *.yml to describe namespace.

@ajgarlag
Copy link
Contributor

To learn how to configure XML Namespaces with YAML metadata you should review https://github.com/schmittjoh/serializer/blob/master/tests/JMS/Serializer/Tests/Metadata/Driver/yml/BlogPost.yml

@jeserkin
Copy link
Contributor Author

Should be fixed now.

schmittjoh added a commit that referenced this pull request Jan 13, 2014
Add XmlNamespace annotation documentation
@schmittjoh schmittjoh merged commit c25955e into schmittjoh:master Jan 13, 2014
@schmittjoh
Copy link
Owner

Thanks!

@jeserkin
Copy link
Contributor Author

@schmittjoh by the way, could you update documentation webpages. They seem to be outdated.

@schmittjoh
Copy link
Owner

These changes should show up there in a couple of hours.

On Mon, Jan 13, 2014 at 11:35 AM, Eugene Serkin [email protected]:

@schmittjoh https://github.com/schmittjoh by the way, could you update
documentation webpages. They seem to be outdated.


Reply to this email directly or view it on GitHubhttps://github.com//pull/213#issuecomment-32158465
.

@marcospassos
Copy link
Contributor

Great work, guys!

2014/1/13 Johannes [email protected]

These changes should show up there in a couple of hours.

On Mon, Jan 13, 2014 at 11:35 AM, Eugene Serkin [email protected]:

@schmittjoh https://github.com/schmittjoh by the way, could you
update
documentation webpages. They seem to be outdated.


Reply to this email directly or view it on GitHub<
https://github.com/schmittjoh/serializer/pull/213#issuecomment-32158465>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/213#issuecomment-32158732
.

@jeserkin
Copy link
Contributor Author

Hmm. Seems there was a mistake before. Didn't notice private $id = 'my_id;, no closing single quote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants