Generate namespaced element on XmlList entries #301

goetas · 2014-07-16T10:12:10Z

Things done with this patch:

Merged XmlList and XmlMap Namespace support #237
Added documentation for XmlList and XmlMap Namespace support #237
@XmlNamespace(uri="http://example.com/namespace") acts as default namespace
XmlDeserializationVisitor
- Removed a lot of XPath stuff in flavor of simpler SimpleXMLElement::children method
- Added $objectMetadataStack to access class metadata from a property
XmlSerializationVisitor
- Removed unnecessary element prefixing when the document/node default namespace match the desired namesapce
- Removed some duplicated code, adding createElement and setAttributeOnNode methods

goetas · 2014-07-18T08:54:19Z

@skler Are you still working on this?

goetas · 2014-07-18T08:57:28Z

@schmittjoh Tests passes on my env (PHPUnit 3.7.28 and PHP 5.5.12)

schmittjoh · 2014-07-18T12:55:09Z

src/JMS/Serializer/XmlSerializationVisitor.php

            } else {
-                $element = $this->document->createElement($elementName);
+                $classMetadata = $this->objectMetadataStack->top();
+                $defaultNamespace = isset($classMetadata->xmlNamespaces[''])?$classMetadata->xmlNamespaces['']:null;


How about adding a method for this to the metadata class, we seem to repeat this in a couple of places.

I'm not sure if an implementation as:

private function getClassDefaultNamespace(ClassMetadata $metadata) { return (isset($metadata->xmlNamespaces[''])?$metadata->xmlNamespaces['']:null); }

would be enough.

put $classMetadata = $this->objectMetadataStack->top(); inside is not possible...

mfoti · 2014-07-22T08:30:33Z

@goetas No, but if you need support I'm here

goetas · 2014-07-23T15:18:01Z

News on this?

goetas · 2014-08-01T09:57:05Z

Tests failures are related to #292 and #300

RSully · 2014-09-26T19:17:09Z

What's holding this up?

natebrunette · 2014-10-30T23:34:54Z

+1

Is there a workaround for this in the meantime? My issue is that the node has a prefix and won't deserialize without specifying it.

mfoti · 2014-12-03T16:36:12Z

@schmittjoh could be integrated this? If you like other fixes tell us.

xcompass · 2014-12-10T06:17:53Z

+1

My current workaround is to remove the namespace prefix before sending it to deserialize.

goetas · 2014-12-20T21:57:20Z

rebased some commits to have a clean commit list

Tobur · 2015-01-26T20:23:16Z

How it's going? I need this functionality 😢

goetas · 2015-01-26T21:27:09Z

@Tobur you can try to use my fork (see here https://github.com/goetas/xsd2php how to use it into your composer.json)

holtkamp · 2015-03-10T21:30:36Z

+1, reluctant to use a fork when a PR seems ready to go...

RSully · 2015-04-03T13:18:23Z

Looks like this needs a rebase. Would love an update.

hiend · 2015-04-07T15:28:48Z

+1

maZahaca · 2015-04-26T11:37:02Z

Hey, what's up here?

discordier · 2015-05-20T00:37:07Z

I also want to leave my +1 on this one here as I just ran into exactly the same wall, array element has to be in a namespace.

symm · 2015-05-29T10:10:14Z

+1

coreequip · 2015-06-15T07:13:59Z

+1

PATROMO · 2015-06-15T07:15:02Z

+1

yceruto · 2015-10-06T13:03:00Z

+1, merge?

netsensei · 2015-10-23T23:09:22Z

+1 for a merge.

goetas · 2015-10-26T07:59:14Z

@schmittjoh any chance to see this merged? i can rebase it again...

brianmc · 2015-11-10T18:58:45Z

+1 for a merge, please let us know if we can help in any way to get this in.

timdev · 2016-01-01T01:58:44Z

+1 for a merge.

slawomirkania · 2016-02-22T10:51:45Z

+1 merge

goetas · 2016-05-05T14:46:24Z

Rebased again.
@schmittjoh Please consider reopening this. There are many use cases for this feature and also many people that have expressed they interest in this

goetas · 2016-05-05T15:10:23Z

Test failures are unrelated and currently on master https://travis-ci.org/schmittjoh/serializer/jobs/126569375

schmittjoh · 2016-05-06T09:55:29Z

src/JMS/Serializer/Metadata/PropertyMetadata.php

@@ -35,6 +35,7 @@ class PropertyMetadata extends BasePropertyMetadata
    public $xmlCollection = false;
    public $xmlCollectionInline = false;
    public $xmlEntryName;
+    public $xmlEntryNamespace;


We should add that to serialize / unserialize a bit further down, no?

schmittjoh · 2016-05-06T09:59:29Z

Sorry for the wait, looks good, can you check the comment above, so we can merge this?

goetas · 2016-05-06T13:29:33Z

done

schmittjoh · 2016-05-06T15:29:55Z

We should probably have an exception if someone deserializes an old version. Could you check the number of elements in unserialize and either throw an exception or set some default for the new property?

goetas · 2016-05-06T15:51:37Z

done

schmittjoh · 2016-05-06T15:55:03Z

Thanks!

mfoti · 2016-05-06T16:13:27Z

#237 can be closed, dunno why I'm not between the contributors :( but happy to see this merged!
Thanks you all guys :)

goetas · 2016-05-06T16:15:55Z

@skler my bad, after almost two years of pending PR yesterday i have rebased it and for some issues with my git repo i have squashed all previous commits into one... sorry, my bad

holtkamp · 2016-05-08T17:00:18Z

@schmittjoh would this justify a new minor release?

see schmittjoh/serializer#301

goetas mentioned this pull request Jul 17, 2014

XmlList and XmlMap Namespace support #237

Closed

goetas changed the title ~~Generate namespaced element on XmlList entries~~ [WIP] Generate namespaced element on XmlList entries Jul 17, 2014

goetas changed the title ~~[WIP] Generate namespaced element on XmlList entries~~ Generate namespaced element on XmlList entries Jul 18, 2014

goetas mentioned this pull request Jul 18, 2014

Namespaces and serialize/deserialize process #303

Closed

schmittjoh reviewed Jul 18, 2014
View reviewed changes

rjelierse mentioned this pull request Sep 4, 2014

Deserialization of XmlList does not support namespaces #332

Closed

goetas mentioned this pull request Sep 26, 2014

Issue when deserializing with jms/serializer goetas/xsd2php#22

Closed

goetas mentioned this pull request Oct 22, 2014

BaseTypeValueHandler documentation would be very handy goetas/xsd2php#29

Closed

goetas force-pushed the ns branch from 303575f to 0cf67eb Compare December 20, 2014 21:56

holtkamp mentioned this pull request Sep 25, 2015

XML namespaces in generated YAML metadata files for nested elements confuse Deserializer goetas/xsd2php#73

Open

goetas force-pushed the ns branch from 0cf67eb to 3f46809 Compare May 5, 2016 14:36

Generate namespaced element on XmlList entries

e5df8e3

goetas force-pushed the ns branch from 3f46809 to e5df8e3 Compare May 5, 2016 14:45

schmittjoh reviewed May 6, 2016
View reviewed changes

Add namespace info to serialized cache

42a2e82

backward compatible unserialization cache

438589a

schmittjoh merged commit 37cc390 into schmittjoh:master May 6, 2016

goetas deleted the ns branch May 14, 2016 09:35

staabm added a commit to staabm/xsd2php that referenced this pull request May 17, 2016

removed ref. to serializer#301 as it was recently merged

8e13c8c

see schmittjoh/serializer#301

staabm mentioned this pull request May 17, 2016

removed ref. to serializer#301 as it was recently merged goetas/xsd2php#110

Closed

goetas added this to the v1.2 milestone Aug 3, 2016

goetas mentioned this pull request Jan 20, 2017

Problem with namespace for XMLList schmittjoh/JMSSerializerBundle#438

Closed

goetas mentioned this pull request Mar 10, 2017

Define cdata and namespace for @XmlList elements #480

Closed

Generate namespaced element on XmlList entries #301

Generate namespaced element on XmlList entries #301

Conversation

goetas commented Jul 16, 2014

goetas commented Jul 18, 2014

goetas commented Jul 18, 2014

schmittjoh Jul 18, 2014

Choose a reason for hiding this comment

goetas Jul 18, 2014

Choose a reason for hiding this comment

mfoti commented Jul 22, 2014

goetas commented Jul 23, 2014

goetas commented Aug 1, 2014

RSully commented Sep 26, 2014

natebrunette commented Oct 30, 2014

mfoti commented Dec 3, 2014

xcompass commented Dec 10, 2014

goetas commented Dec 20, 2014

Tobur commented Jan 26, 2015

goetas commented Jan 26, 2015

holtkamp commented Mar 10, 2015

RSully commented Apr 3, 2015

hiend commented Apr 7, 2015

maZahaca commented Apr 26, 2015

discordier commented May 20, 2015

symm commented May 29, 2015

coreequip commented Jun 15, 2015

PATROMO commented Jun 15, 2015

yceruto commented Oct 6, 2015

netsensei commented Oct 23, 2015

goetas commented Oct 26, 2015

brianmc commented Nov 10, 2015

timdev commented Jan 1, 2016

slawomirkania commented Feb 22, 2016

goetas commented May 5, 2016

goetas commented May 5, 2016

schmittjoh May 6, 2016

Choose a reason for hiding this comment

schmittjoh commented May 6, 2016

goetas commented May 6, 2016

schmittjoh commented May 6, 2016

goetas commented May 6, 2016

schmittjoh commented May 6, 2016

mfoti commented May 6, 2016

goetas commented May 6, 2016

holtkamp commented May 8, 2016