Fix detecting doctype for whitelisting. #508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comments? |
Closed
|
ping @schmittjoh. Connected with #511 - choose the solution for test fix :) |
|
this is probably outdated now |
|
I'll check. What has been pulled, then? |
|
Part of fixes included in #578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "fix" restores the original behavior of doctype whitelisting (also - makes the unit tests pass).
The doctype whitelisting works on the whole "<!DOCTYPE" declaration. But in recent PHP versions the internalSubtype returns (correctly) only, well, the INTERNAL subtype declaration for a doctype.
Existing code tried to compensate this and worked for doctypes without internal entity declarations.
This PR restores the original behavior also for doctypes with internal entity declarations.
This is connected to #427 (although the original issue was closed).