Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Doctrine PHPCR ODM 2.0 compatibility #605

Merged
merged 1 commit into from
Aug 12, 2016
Merged

Fix Doctrine PHPCR ODM 2.0 compatibility #605

merged 1 commit into from
Aug 12, 2016

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Jul 5, 2016

This available since PHPCR ODM 1.1 and the old method is removed in 2.0.

@wouterj wouterj mentioned this pull request Jul 9, 2016
Merged
@goetas
Copy link
Collaborator

goetas commented Jul 26, 2016 •
edited
Loading

As i can see, https://github.com/doctrine/phpcr-odm/tree/2.0 is not yet tagged (released)

@goetas
Copy link
Collaborator

goetas commented Jul 26, 2016

i guess you should change composer.json too

wouterj added a commit to wouterj/phpcr-odm that referenced this pull request Aug 3, 2016
@wouterj
Temporary revert getField() removal
bd5f618 
Some slow moving vendor dependencies (like JMS Serializer, ref
schmittjoh/serializer#605) hold up the development at the moment. Keeping
this method for the moment will fix it.

This commit should be reverted before 2.0.0 is released.
@wouterj wouterj mentioned this pull request Aug 3, 2016
Merged
@goetas goetas added this to the v1.3 milestone Aug 3, 2016
@goetas
Copy link
Collaborator

goetas commented Aug 3, 2016

@wouterj ping

@wouterj
Copy link
Contributor Author

wouterj commented Aug 3, 2016

As i can see, https://github.com/doctrine/phpcr-odm/tree/2.0 is not yet tagged (released)

Indeed. But as the doctrine/phpcr-odm is a dev requirement, this package can be installed with PHPCR ODM 2.0-dev. This case is currently broken (and is holding up development of CMF 2.0 / PHPCR 2.0, as we rely on JMS serializer).

Updated the composer.json file.

@wouterj
Copy link
Contributor Author

wouterj commented Aug 3, 2016

Btw, cool to see some development progress in this repository again! :)

@goetas
Copy link
Collaborator

goetas commented Aug 3, 2016

👍
looks good

@goetas goetas merged commit 3e58b5c into schmittjoh:master Aug 12, 2016
@wouterj
Copy link
Contributor Author

wouterj commented Aug 12, 2016

Thanks!

Op vr 12 aug. 2016 22:04 schreef Asmir Mustafic [email protected]:

Merged #605 #605.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#605 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAtt4dDPt3zRANgKgch5P09pX727hEeXks5qfNHZgaJpZM4JFY_J
.

dbu pushed a commit to doctrine/phpcr-odm that referenced this pull request Aug 31, 2016
@wouterj @dbu
Temporary revert getField() removal
16475ab 
Some slow moving vendor dependencies (like JMS Serializer, ref
schmittjoh/serializer#605) hold up the development at the moment. Keeping
this method for the moment will fix it.

This commit should be reverted before 2.0.0 is released.
dbu pushed a commit to doctrine/phpcr-odm that referenced this pull request Aug 31, 2016
@wouterj @dbu
Temporary revert getField() removal
29744be 
Some slow moving vendor dependencies (like JMS Serializer, ref
schmittjoh/serializer#605) hold up the development at the moment. Keeping
this method for the moment will fix it.

This commit should be reverted before 2.0.0 is released.
dbu pushed a commit to doctrine/phpcr-odm that referenced this pull request Aug 31, 2016
@wouterj @dbu
Temporary revert getField() removal
4aa1475 
Some slow moving vendor dependencies (like JMS Serializer, ref
schmittjoh/serializer#605) hold up the development at the moment. Keeping
this method for the moment will fix it.

This commit should be reverted before 2.0.0 is released.
dbu pushed a commit to doctrine/phpcr-odm that referenced this pull request Jan 17, 2017
@wouterj @dbu
Temporary revert getField() removal
1338d83 
Some slow moving vendor dependencies (like JMS Serializer, ref
schmittjoh/serializer#605) hold up the development at the moment. Keeping
this method for the moment will fix it.

This commit should be reverted before 2.0.0 is released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
To Merge
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@wouterj @goetas