Add format output option #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyrtonRicardo
commented
Sep 8, 2016
AyrtonRicardo
commented
- Add test
- Add format output option
- Add test
|
this is a XML specific option, and should not be part of the global context. have a look to https://github.com/schmittjoh/serializer/blob/master/src/JMS/Serializer/JsonSerializationVisitor.php#L48 for an alternative implementation. 4be3f29 added a similar feature for JSON |
|
@goetas I agree with you. I'll do PR to SerializerBundle with the option on the DI after your OK here! 😄 |
|
looks good to me! 👍 |
| @@ -44,10 +44,14 @@ class XmlSerializationVisitor extends AbstractVisitor | |||
| private $nullWasVisited; | |||
| private $objectMetadataStack; | |||
|
|
|||
| /** @var boolean */ | |||
| private $formatOutput; | |||
There was a problem hiding this comment.
set it default to false, please
we had some bugs fro such kind of implementation (#317)
There was a problem hiding this comment.
It's default true, setted on constructor. It's default true because it was true before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.