[Annotation] Added the ability to set the type when using @VirtualProperty

[pylebecq]

As discussed in nelmio/NelmioApiDocBundle#161, I added the ability to force the type of a virtual property when using the @VirtualProperty annotation.

Comments are always welcome :)

[stof]

Wouldn't it be better to use the @Type annotation ?

[pylebecq]

I don't know. I talked about that in the discussion nelmio/NelmioApiDocBundle#161 but I thought you guys didn't see it.
Sorry if I misunderstood.

@schmittjoh Do you prefer the use of the @Type annotation ?

[schmittjoh]

Yeah, using the @type annotation is more consistent with all the other
annotations.

On Thu, Mar 28, 2013 at 2:51 PM, Pierre-Yves LEBECQ <
[email protected]> wrote:

I don't know. I talked about that in the discussion
nelmio/NelmioApiDocBundle#161https://github.com/nelmio/NelmioApiDocBundle/issues/161but I thought you guys didn't see it. I thought you were
Sorry if I misunderstood.

@schmittjoh https://github.com/schmittjoh Do you prefer the use of the
@type annotation ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/69#issuecomment-15589306
.

[pylebecq]

That was easier than I though this way.

[schmittjoh]

Could you add a small test-case? Just so that we avoid regressions later.

[pylebecq]

I added a test case but there is something odd : adding a new virtual property in ObjectWithVirtualProperties.php changes the order of the properties. That's why I had to switch some positions in the test files.
Maybe it's normal but I don't understand why. Any hint ?

[schmittjoh]

Did you run the test-case before you added the new property and was it
successful?

On Thu, Mar 28, 2013 at 4:31 PM, Pierre-Yves LEBECQ <
[email protected]> wrote:

I added a test case but there something odd : adding a new virtual
property in ObjectWithVirtualProperties.php change the order of the
properties. That why I had to switch some positions in the test files.
Maybe it's normal but I don't understand why. Any hint ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/69#issuecomment-15594927
.

[pylebecq]

Yes.

[schmittjoh]

Must be some weird PHP behavior, but as long as there is no explicit order requested, it's basically undefined; so, it should not bother us too much.

I've merged the changes in.

[pylebecq]

Thanks.