#720 - Adding support for DateInterval deserialization #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
reviewed
Mar 6, 2017
| try { | ||
| $dateInterval = new \DateInterval($data); | ||
| } catch (\Exception $e) { | ||
| throw new RuntimeException(sprintf('Invalid dateinterval "%s", expected ISO 8601 format', $data)); |
There was a problem hiding this comment.
what about adding the previous exception ($e) as third argument of RuntimeException ?
There was a problem hiding this comment.
I was just copying the one example of catching and rethrowing an exception within the project to keep things consistent, but I'm happy to add that as a 3rd param. It makes sense.
There was a problem hiding this comment.
Added rethrow of exception
|
@c0ntax thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in DateInterval deserialization and associated unit test
Fixes #720