Fix stdClass inconsistencies when serializing to JSON #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
commented
Mar 13, 2017
| @@ -263,7 +265,85 @@ public function testSerializeWithNonUtf8EncodingWhenDisplayErrorsOn() | |||
|
|
|||
| public function testSerializeArrayWithEmptyObject() | |||
| { | |||
| $this->assertEquals('{"0":{}}', $this->serialize(array(new \stdClass()))); | |||
| $this->assertEquals('[{}]', $this->serialize(array(new \stdClass()))); | |||
There was a problem hiding this comment.
this to me sounds a wrong test case.
There was a problem hiding this comment.
@schmittjoh What do you think?
This was referenced Apr 14, 2017
Merged
goetas
force-pushed
the
std-class-and-cleanup
branch
from
c02fecf
to
ca3bf73
Compare
…tion for the json visitor
…er object is a empty stdclass is obviously wrong
goetas
force-pushed
the
std-class-and-cleanup
branch
from
ca3bf73
to
39f8401
Compare
goetas
changed the title
This was referenced Apr 24, 2017
|
With the class |
|
I really do not suggest to use But to answer to your question, using directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
Closes #59
Closes #242