Improve documentation about default DateTime format #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
enumag
commented
Nov 14, 2017
enumag
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Doc updated | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| Fixed tickets | #836 |
| License | Apache-2.0 |
enumag
commented
Nov 14, 2017
| @@ -388,6 +388,8 @@ Available Types: | |||
| | | into Doctrine's ArrayCollection class. | | |||
| +----------------------------------------------------------+--------------------------------------------------+ | |||
|
|
|||
| *) If the standalone jms/serializer is used then default format is `\DateTime::ISO8601` (which is not compatible with ISO-8601 despite the name). For jms/serializer-bundle the default format is `\DateTime::ATOM` (the real ISO-8601 format) but it can be changed in [configuration](https://jmsyst.com/bundles/JMSSerializerBundle/master/configuration#configuration-block-2-0). | |||
There was a problem hiding this comment.
I'm not sure how to make the link correctly. This is probably not how it's supposed to be.
There was a problem hiding this comment.
(which is not compatible with ISO-8601 despite the name).
can you elaborate? why is not compatible?
There was a problem hiding this comment.
See PHP documentation: http://php.net/manual/en/class.datetime.php#datetime.constants.atom
DateTime::ISO8601
DATE_ISO8601
ISO-8601 (example: 2005-08-15T15:52:01+0000)
Note: This format is not compatible with ISO-8601, but is left this way for backward compatibility reasons. Use DateTime::ATOM or DATE_ATOM for compatibility with ISO-8601 instead.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.