-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for monitoring IAM access #15
Conversation
abe1b0b
to
d675126
Compare
fc16d1b
to
65b9bc1
Compare
cb01ced
to
e9e06b1
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great @fgoncalves-io, have a minor q regarding casing in an SNS topic name but otherwise ready to go I think!
|
||
data "aws_sns_topic" "all_config_notifications" { | ||
provider = aws.audit | ||
name = "aws-controltower-AllConfigNotifications" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to capitalise certain letters shouldn't we do it the whole string, e.g.
name = "aws-controltower-AllConfigNotifications" | |
name = "AWS-ControlTower-AllConfigNotifications" |
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah fair enough, if it's inline with other resources then all is good 👍
This PR adds the capability of monitoring the activity of the
root
user and any other IAM User or IAM Role.The main purpose of this change is to monitor when users with privileged access interact with our accounts. The CloudWatch Rule pattern will look for both Console and API activity.
For the core accounts, the
root
user will be automatically monitored and all activities will be reported to the topicLandingZone-MonitorIAMAccess
in theaudit
account.For the
avm
created accounts, the monitoring is optional and can be enabled by passing the ARN of SNS Topic that should receive notifications. If enabled, theroot
user of the account will also be automatically monitored.