Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported services and use uniq policy names #155

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

sbkg0002
Copy link
Contributor

  • Remove unsupported services from tag policies
  • Use uniq tag policy names

@sbkg0002 sbkg0002 force-pushed the ensure-uniq-names branch 3 times, most recently from 1f787d0 to c799231 Compare December 14, 2022 09:46
@github-actions
Copy link
Contributor

terraform validate Failed

╷
│ Error: Reference to undeclared local value
│ 
│   on modules/tag-policy-assignment/main.tf line 9, in resource "aws_organizations_policy" "required_tags":
│    9:   name = "LandingZone-RequiredTags-${local.ou_name}-${each.key}"
│ 
│ A local value with the name "ou_name" has not been declared.
╵

Workflow: Terraform, Action: __hashicorp_terraform-github-actions_2, Working Directory: ., Workspace: default

* Remove unsupported services from tag policies
@sbkg0002 sbkg0002 marked this pull request as ready for review December 14, 2022 09:48
Copy link

@dennisbrouwer91 dennisbrouwer91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbkg0002 sbkg0002 merged commit 642e472 into master Dec 14, 2022
@sbkg0002 sbkg0002 deleted the ensure-uniq-names branch December 14, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants