Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in the aws_sns_topic_subscription.datadog_security resource #60

Merged
merged 5 commits into from
Jan 6, 2021

Conversation

marwinbaumannsbp
Copy link
Contributor

  • Resolves issue where leaving the sns_security_subscription variable empty would cause failure.
  • Renamed and restructured the sns_security_subscription variable into sns_aws_config_subscription. Changed into a map to prevent the endpoint being used in the for_each. The endpoint can contain a secret (e.g. the datadog api key) and this would cause failure. In TF V0.14 you can't use for_each with an object that has sensitive values.
  • Moved this resource out of the security_hub module since the SNS topic aws-controltower-AggregateSecurityNotifications only contains AWS Config data: https://docs.aws.amazon.com/controltower/latest/userguide/compliance.html

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Stephen Hoekstra <[email protected]>
@marwinbaumannsbp marwinbaumannsbp merged commit 8ba7e86 into master Jan 6, 2021
@marwinbaumannsbp marwinbaumannsbp deleted the fix-sns-bug branch January 6, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants