Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TFE agent pool support to AVM #98

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Conversation

shoekstra
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

terraform validate Failed


Error: Missing required argument

  on main.tf line 52, in module "workspace":
  52: module "workspace" {

The argument "repository_name" is required, but no definition was found.


Error: Unsupported argument

  on main.tf line 62, in module "workspace":
  62:   github_organization    = var.defaults.github_organization

An argument named "github_organization" is not expected here.


Error: Unsupported argument

  on main.tf line 63, in module "workspace":
  63:   github_repository      = var.name

An argument named "github_repository" is not expected here.

Workflow: Terraform, Action: hashicorpterraform-github-actions2, Working Directory: ./modules/avm, Workspace: default

@github-actions
Copy link
Contributor

Terraform Security Scan Failed

Show Output
Check 1

  [AWS063][WARNING] Resource 'aws_cloudtrail.additional_auditing_trail' does not set multi region trail config.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS063/ for more information. 

Check 2

  [AWS064][WARNING] Resource 'aws_cloudtrail.additional_auditing_trail' does not enable log file validation.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS064/ for more information. 

Check 3

  [AWS065][ERROR] Resource 'aws_cloudtrail.additional_auditing_trail' does not have a kms_key_id set.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS065/ for more information. 

  times
  ------------------------------------------
  disk i/o             8.622191ms
  parsing HCL          36.9µs
  evaluating values    10.698714ms
  running checks       3.081432ms

  counts
  ------------------------------------------
  files loaded         10
  blocks               98
  evaluated blocks     98
  modules              0
  module blocks        0

3 potential problems detected.

@github-actions
Copy link
Contributor

Terraform Security Scan Failed

Show Output
Check 1

  [AWS063][WARNING] Resource 'aws_cloudtrail.additional_auditing_trail' does not set multi region trail config.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS063/ for more information. 

Check 2

  [AWS064][WARNING] Resource 'aws_cloudtrail.additional_auditing_trail' does not enable log file validation.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS064/ for more information. 

Check 3

  [AWS065][ERROR] Resource 'aws_cloudtrail.additional_auditing_trail' does not have a kms_key_id set.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS065/ for more information. 

  times
  ------------------------------------------
  disk i/o             7.917817ms
  parsing HCL          36.101µs
  evaluating values    10.310353ms
  running checks       3.156247ms

  counts
  ------------------------------------------
  files loaded         10
  blocks               98
  evaluated blocks     98
  modules              0
  module blocks        0

3 potential problems detected.

@github-actions
Copy link
Contributor

terraform validate Failed


Error: Missing required argument

  on main.tf line 52, in module "workspace":
  52: module "workspace" {

The argument "repository_name" is required, but no definition was found.


Error: Unsupported argument

  on main.tf line 62, in module "workspace":
  62:   github_organization    = var.defaults.github_organization

An argument named "github_organization" is not expected here.


Error: Unsupported argument

  on main.tf line 63, in module "workspace":
  63:   github_repository      = var.name

An argument named "github_repository" is not expected here.

Workflow: Terraform, Action: hashicorpterraform-github-actions2, Working Directory: ./modules/avm, Workspace: default

jaytjon
jaytjon previously approved these changes Mar 19, 2021
Signed-off-by: Stephen Hoekstra <[email protected]>
@github-actions
Copy link
Contributor

terraform validate Failed


Error: Missing required argument

The argument "token" is required, but was not set.

Workflow: Terraform, Action: hashicorpterraform-github-actions2, Working Directory: ./modules/avm, Workspace: default

@github-actions
Copy link
Contributor

Terraform Security Scan Failed

Show Output
Check 1

  [AWS063][WARNING] Resource 'aws_cloudtrail.additional_auditing_trail' does not set multi region trail config.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS063/ for more information. 

Check 2

  [AWS064][WARNING] Resource 'aws_cloudtrail.additional_auditing_trail' does not enable log file validation.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS064/ for more information. 

Check 3

  [AWS065][ERROR] Resource 'aws_cloudtrail.additional_auditing_trail' does not have a kms_key_id set.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS065/ for more information. 

  times
  ------------------------------------------
  disk i/o             9.209446ms
  parsing HCL          38.4µs
  evaluating values    10.310452ms
  running checks       3.439217ms

  counts
  ------------------------------------------
  files loaded         10
  blocks               98
  evaluated blocks     98
  modules              0
  module blocks        0

3 potential problems detected.

Signed-off-by: Stephen Hoekstra <[email protected]>
@github-actions
Copy link
Contributor

Terraform Security Scan Failed

Show Output
Check 1

  [AWS065][ERROR] Resource 'aws_cloudtrail.additional_auditing_trail' does not have a kms_key_id set.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS065/ for more information. 

Check 2

  [AWS063][WARNING] Resource 'aws_cloudtrail.additional_auditing_trail' does not set multi region trail config.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS063/ for more information. 

Check 3

  [AWS064][WARNING] Resource 'aws_cloudtrail.additional_auditing_trail' does not enable log file validation.
  /github/workspace/main.tf:1-7

       1 | resource "aws_cloudtrail" "additional_auditing_trail" {
       2 |   count                 = var.additional_auditing_trail != null ? 1 : 0
       3 |   name                  = var.additional_auditing_trail.name
       4 |   s3_bucket_name        = var.additional_auditing_trail.bucket
       5 |   is_organization_trail = true
       6 |   tags                  = var.tags
       7 | }
       8 | 
       9 | resource "aws_cloudwatch_log_metric_filter" "iam_activity_master" {
      10 |   for_each = var.monitor_iam_activity ? local.iam_activity : {}

   See https://tfsec.dev/docs/aws/AWS064/ for more information. 

  times
  ------------------------------------------
  disk i/o             8.30825ms
  parsing HCL          38.602µs
  evaluating values    11.27924ms
  running checks       2.927688ms

  counts
  ------------------------------------------
  files loaded         10
  blocks               98
  evaluated blocks     98
  modules              0
  module blocks        0

3 potential problems detected.

@shoekstra shoekstra merged commit f15cf43 into master Mar 19, 2021
@shoekstra shoekstra deleted the avm/add_tfe_agent_pool_id branch March 19, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants