Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated lambda packages are not uploaded to S3 #51

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: updated lambda packages are not uploaded to S3 #51

merged 1 commit into from
Oct 30, 2024

Conversation

mlflr
Copy link
Contributor

@mlflr mlflr commented Oct 30, 2024

Because of missing hash checks in

  • resource "aws_s3_object" "findings_manager_lambdas_deployment_package"
  • resource "aws_s3_object" "jira_lambda_deployment_package"

updated package would not be uploaded to S3 and as a consequence not update the lambda.

This PR adds an source_hash to ensure that it gets updated.

@github-actions github-actions bot added the bug Something isn't working label Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️``

Terraform Lint 📖success

Terraform Validation 🤖success

Validation Output 

Success! The configuration is valid.

@mlflr mlflr merged commit f751ef1 into main Oct 30, 2024
7 checks passed
@mlflr mlflr deleted the fix-lambda-package-update branch October 30, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwinbaumannsbp marwinbaumannsbp marwinbaumannsbp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlflr @marwinbaumannsbp