add the possibility to set a build_extensions option in the build.yaml #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schultek
requested changes
Nov 12, 2023
| @@ -138,6 +137,7 @@ class MappableBuilder implements Builder { | |||
|
|
|||
| output.write('}'); | |||
|
|
|||
| final outputId = buildStep.allowedOutputs.last; | |||
There was a problem hiding this comment.
Please also adjust the code regarding writeImports (see line 125 and 153) , since this currently assumes the output is under the same path as the input.
There was a problem hiding this comment.
I attempted to follow your instructions, but please double-check them, as I'm uncertain about what you wanted.
|
Also, closes #138 |
Closed
|
I corrected the import paths. |
schultek
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now add a
yaml options: build_extensions: 'lib/{{path}}/{{file}}.dart': ['lib/{{path}}/generated/{{file}}.mapper.dart', 'lib/{{path}}/generated/{{file}}.init.dart']To a build.yaml to specify where to put the built files.
I did not find any mappableContainer in the exemples so I'm not shure that it works perfectly for the mappablecontainer. For the others generation, it works like a charm.