fix: prepare for artifact v4 #335
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
...r.project_name}}/.github/workflows/{% if cookiecutter.__type=='compiled' %}cd.yml{% endif %}
Outdated
Show resolved
Hide resolved
|
given the incompatibility, I guess baipp should be bumped to v2? |
|
I think that's a perfect (as in as best as this mess can be) solution, thanks! I'm going to push then then as soon as it's tested (CMake 3.28.0 has a segfault, and I don't have permissions to yank, so dealing with this right now in cmake-python-distributions, where someone already merged the v4 updates, thinking they were broken because they were incompatible, not realizing the merging issue would persist after both were updated, and now can't move forward with getting 3.28.1 out...) I think we should also suggest Dependabot's new grouping feature (probably as a repo-review check), as that wouldn't have happened if both v4 updates were grouped together. |
|
|
...r.project_name}}/.github/workflows/{% if cookiecutter.__type=='compiled' %}cd.yml{% endif %}
Outdated
Show resolved
Hide resolved
I can't actually start suggesting v4 until @hynek's build-and-inspect-python-package updates, since we suggest using that for pure Python packages, and v1-v3 upload/download is not cross compatible with v4. Features of v4 are here: https://github.com/actions/toolkit/tree/main/packages/artifact#v2---whats-new - sounds nice, though the immutable artifacts is a hard one (see pypa/cibuildwheel#1699 too). There's an issue asking for guidance here: actions/upload-artifact#472.