-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude openblas-libs from the cleanup job #34
Comments
It seems there is a retention policy for packages that the remove-wheels github action implements. Perhaps the policy could be added to SPEC-04 and the org description could add some detail or point to the SPEC. |
The technical answer is easy. Just after upload-nightly-action/.github/workflows/remove-wheels.yml Lines 52 to 56 in 2b318b6
insert
as part of the "Query package index for packages" step.
The question of if packages that aren't meant to be removed and aren't actually nightlies should be housed here or not seems related to Issue #30. |
@mattip @honno Can you confirm that all the versions that are current uploaded ( @bsipocz has already assigned herself to this Issue (:+1:), but I just wanted to get this clarified as if |
The opnblas-libs are more like PyPI artifacts, in that various versions of NumPy and Scipy will ask for various versions of these artifacts. The versions are specified in a script, here for NumPy and here for Scipy (which is still using the old site for the non-nightly version). Version This discussion is one more reason to turn the openblas tarballs into wheels, see MacPython/openblas-libs#86. |
Thanks for verifying @mattip. As |
My request still stands: please exclude openblas-libs from the cleanup job, regardless of ongoing conversations about whether the use of this site is a good fit for openblas-libs. I may be wrong about the need for the artifact about to be deleted, and it would be a shame to break somebody's build. |
👋 @mattip The This is currently fine, but as you asked that all automated removal of the files be excluded for these files, what is the |
Once numpy/numpy#25505 goes in, and a similar PR can be made to SciPy, we will stop uploading tarballs and only upload wheels (scipy-openblas64 and scipy-openblas32). |
@mattip very cool! Congrats in advance and well done to you and the rest of the team on this work. edit: Though does that mean that the wheel can be treated as normal and no longer need to be reserved artifacts that can't be cleaned up? |
The wheel or the tarballs? The tarballs (at openblas-libs) will still be used by older builds of maintenance versions and by third-party projects for a while. I don't think the wheels (at scipy-openblas64 and scipy-openblas32) were ever reserved artifacts, only the tarballs, right? |
Right.
Okay, I think this answers my question, thanks. There can be some natural phase out period where at some future point (would you project 1 year as reasonable?) the tarballs can be removed, and then just the wheels can remain and those can get cycled at the same rates as the rest of the projects. 👍 |
Congratulations @mattip to you and the rest of the team on getting numpy/numpy#25505 in! 🎉 That seems like a heroic amount of work that has been done, but seems exciting. For those of us who haven't been fully tracking this work (i.e. me) and its ramifications for NumPy and SciPy wheels, can you or @rgommers give just a bullet list, to compliment #34 (comment), of what this means moving forward for what will get uploaded to the scientific-python-nightly-wheels Anaconda org, and what Issues or PRs interested parites should be watching? I think the answer to the first part, given #34 (comment), is that we should soon expect there to be no new |
Issues/PRs to watch (running list): |
The files at https://anaconda.org/scientific-python-nightly-wheels/openblas-libs/files are not meant to be cleaned up automatically. We generate those tarballs (which are not conda packages) for long-term use by SciPy and NumPy. Is there a way to exclude them from https://github.com/scientific-python/upload-nightly-action/blob/main/.github/workflows/remove-wheels.yml ? If not we should go back to keeping them at https://anaconda.org/multibuild-wheels-staging/openblas-libs/
CC @honno, @rgommers
The text was updated successfully, but these errors were encountered: