-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Remove package versions older than 30 days #33
Conversation
* Add curl and jq to environment requirements. * Use output from the anaconda.org API to get latest upload time for each release of a package. If the upload date is older than 30 days add the package release for removal. * Use anaconda.org API over anaconda-client CLI API to get package versions as easier to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, besides one possible corner case.
If it doesn't make the removal loop to error out, then all looks good to go from my side.
|
||
# Don't need to check for duplicate versions added to removal | ||
# given nightly CRON basis. | ||
for package_version in $(cat package-versions.txt); do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much a corner case, but could it still produce a duplicate when the No6 is just crosses the 30-day threshold?
(but then, if removing a non-existing package in the removal loop below doesn't raise an error, then this is not a problem at all)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #31
Running this now (with the remove step commented out) gives
With regards to why the
numpy
v1.25.0rc1
andscipy
v1.10.1
distributions are missing a last uploaded date c.f. anaconda/anaconda-client#682 (comment)