FIX: Use correct shell variable in upload #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
feel free to ping me when this is ready to go in |
matthewfeickert
force-pushed
the
fix/get-ci-passing
branch
from
3579f34
to
15c30fb
Compare
* Use the correct shell variable "LABEL_ARGS" to pass the lable args to the `anaconda upload` command. - Amends PR #47 * Note that it is important that ${LABEL_ARGS} is NOT quoted during shell parameter expansion, else it will be treated as a file path to anaconda upload and not an argument. - e.g. This will trigger `File "--label main " does not exist` errors.
matthewfeickert
force-pushed
the
fix/get-ci-passing
branch
from
15c30fb
to
0921408
Compare
matthewfeickert
temporarily deployed
to
remove-old-wheels
GitHub Actions
Inactive
bsipocz
approved these changes
Jan 24, 2024
Indeed. More motivation to find a way to have this be PR friendly and security safe in 2024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #52
anaconda uploadcommand.anaconda_nightly_upload_organizationargument #47${LABEL_ARGS}is NOT quoted during shell parameter expansion, else it will be treated as a file path to anaconda upload and not an argument.File "--label main " does not existerrors.