Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 footer/login missing from base domain? #211

Closed
1 task
Tracked by #203
ShanaLMoore opened this issue Apr 26, 2024 · 2 comments
Closed
1 task
Tracked by #203

🐛 footer/login missing from base domain? #211

ShanaLMoore opened this issue Apr 26, 2024 · 2 comments
Assignees
@kirkkwang
Labels
bug something isn't working high priority Hyku Prime

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Apr 26, 2024 •
edited
Loading

Summary

⚠️ Reference this branch for your base, if it hasn't already been merged into main. ⚠️ [ this branch has since been merged ]

Locally, going to hyku.test looks weird, doesn't it?

Is it missing a footer?

NOT LOGGED IN

Image

LOGGED IN (manually had to go to /user/sign_in)

image

This is how demo.hyku-demo looks like:

image

Acceptance Criteria

Screenshots or Video

Testing Instructions

Notes
@ShanaLMoore ShanaLMoore mentioned this issue Apr 26, 2024
Closed
12 tasks
@ShanaLMoore ShanaLMoore added bug something isn't working Hyku Prime labels Apr 26, 2024
@ShanaLMoore ShanaLMoore mentioned this issue Apr 26, 2024
Open
9 tasks
@ShanaLMoore
Copy link
Contributor Author

marking as high priority because user has no way to login unless they know to go directly to the url path

@kirkkwang kirkkwang self-assigned this May 6, 2024
kirkkwang added a commit to samvera/hyku that referenced this issue May 6, 2024
@kirkkwang
🐛 Bring back footer for splash page
7b9bb2e 
This commit will bring the footer back for the splash page as well as
retain the footer display on the homepage.

ref:
  - scientist-softserv/hykuup_knapsack#211
@kirkkwang kirkkwang mentioned this issue May 6, 2024
Merged
@ShanaLMoore
Copy link
Contributor Author

QA: Pass ✅

When logged in:

Image

When logged out:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirkkwang kirkkwang

Labels
bug something isn't working high priority Hyku Prime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShanaLMoore @kirkkwang