410 file analytics #477
Merged
410 file analytics #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring that the class gets required. Legato dynamically creates methods based on classes/modules that extend it’s model. And depending on the load sequence of classes, these dynamic methods can vary. By adding an explicit require, we ensure that those methods are properly defined on the profile. co-authored-by: jeremy <[email protected]>
|
@orangewolf @jeremyf and I would like your feedback on the solution here. it incorporates the changes from hyrax#5958, but the code still failed without the do you have a better solution? |
orangewolf
requested changes
May 16, 2023
|
rob and I paired on the refactor. merging. |
1 task
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
We needed to change the method to reference a class that exists, ensuring that the class gets required.
Legato dynamically creates methods based on classes/modules that extend it’s model. And depending on the load sequence of classes, these dynamic methods can vary. By adding an explicit require, we ensure that those methods are properly defined on the profile.
Expected Behavior Before Changes
trying to view the analytics for a file would fail
Expected Behavior After Changes
we can view file analytics
Screenshots / Video
resources