Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: flatten() #1148

Merged
merged 11 commits into from
Nov 22, 2021
Merged

C++ refactoring: flatten() #1148

merged 11 commits into from
Nov 22, 2021

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Nov 14, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #1148 (235476f) into main (f795658) will increase coverage by 1.07%.
The diff coverage is 76.80%.

Impacted Files Coverage Δ
src/awkward/_v2/forms/bitmaskedform.py 75.64% <ø> (ø)
src/awkward/_v2/forms/bytemaskedform.py 76.05% <ø> (ø)
src/awkward/_v2/forms/emptyform.py 78.84% <ø> (+1.92%) ⬆️
src/awkward/_v2/forms/indexedoptionform.py 76.81% <ø> (ø)
src/awkward/_v2/forms/listform.py 75.94% <ø> (ø)
src/awkward/_v2/forms/listoffsetform.py 80.55% <ø> (ø)
src/awkward/_v2/forms/recordform.py 66.46% <ø> (ø)
src/awkward/_v2/forms/regularform.py 75.34% <ø> (ø)
src/awkward/_v2/forms/unionform.py 76.19% <ø> (ø)
src/awkward/_v2/forms/unmaskedform.py 74.57% <ø> (ø)
... and 67 more

@ioanaif ioanaif marked this pull request as ready for review November 22, 2021 16:49
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed it all carefully, and it looks great. Thanks!

@ioanaif ioanaif merged commit 80cc338 into main Nov 22, 2021
@ioanaif ioanaif deleted the ioanaif/flatten branch November 22, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants