Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumpyArray::numbers_to_type must use flattened_length, not length. #1175

Merged
merged 1 commit into from
Dec 8, 2021
Merged

NumpyArray::numbers_to_type must use flattened_length, not length. #1175

merged 1 commit into from
Dec 8, 2021

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski jpivarski linked an issue Dec 6, 2021 that may be closed by this pull request
ak.values_astype produces incorrect results for 2D NumPy array #1173
Closed
@jpivarski jpivarski enabled auto-merge (squash) December 6, 2021 20:16
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #1175 (6c8db14) into main (9955401) will decrease coverage by 0.03%.
The diff coverage is 37.50%.

Impacted Files Coverage Δ
src/awkward/_v2/_connect/pyarrow.py 83.33% <0.00%> (-0.48%) ⬇️
src/awkward/_v2/forms/recordform.py 66.46% <0.00%> (ø)
src/awkward/_v2/contents/recordarray.py 76.80% <50.00%> (-0.46%) ⬇️

@jpivarski jpivarski merged commit cc83056 into main Dec 8, 2021
@jpivarski jpivarski deleted the jpivarski/numbers_to_type-length branch December 8, 2021 00:30
@agoose77 agoose77 mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ak.values_astype produces incorrect results for 2D NumPy array
1 participant
@jpivarski