Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ refactoring: Implemented v2 ak.to_list and switched all v2 tests to use it. #1201

Merged
merged 1 commit into from
Jan 5, 2022
Merged

C++ refactoring: Implemented v2 ak.to_list and switched all v2 tests to use it. #1201

merged 1 commit into from
Jan 5, 2022

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski jpivarski enabled auto-merge (squash) January 5, 2022 19:47
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #1201 (5c5bf47) into main (1751ffc) will increase coverage by 0.00%.
The diff coverage is 54.05%.

Impacted Files Coverage Δ
.../awkward/_v2/operations/structure/ak_singletons.py 80.00% <ø> (ø)
src/awkward/_v2/operations/convert/ak_to_list.py 50.00% <42.30%> (-30.00%) ⬇️
src/awkward/_v2/highlevel.py 64.79% <66.66%> (+0.02%) ⬆️
src/awkward/_v2/_connect/pyarrow.py 83.28% <100.00%> (-0.05%) ⬇️
src/awkward/_v2/_util.py 82.08% <100.00%> (+0.18%) ⬆️
src/awkward/_v2/contents/unionarray.py 83.40% <0.00%> (+2.00%) ⬆️

@jpivarski jpivarski merged commit 3e0b962 into main Jan 5, 2022
@jpivarski jpivarski deleted the jpivarski/ak.to_list branch January 5, 2022 20:22
jpivarski added a commit that referenced this pull request Jan 5, 2022
@jpivarski
Don't let ak.to_list act on v2 arrays (finishing #1201).
2c54cc8
jpivarski added a commit that referenced this pull request Jan 5, 2022
@jpivarski
Don't let ak.to_list act on v2 arrays (finishing #1201). (#1203)
5463c40
@jpivarski jpivarski changed the title Implemented v2 ak.to_list and switched all v2 tests to use it. C++ refactoring: Implemented v2 ak.to_list and switched all v2 tests to use it. Jan 17, 2022
@agoose77 agoose77 mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpivarski