Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: ak.parameters #1242

Merged
merged 3 commits into from
Jan 27, 2022
Merged

C++ refactoring: ak.parameters #1242

merged 3 commits into from
Jan 27, 2022

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Jan 21, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #1242 (d0898d5) into main (ab65e20) will increase coverage by 0.20%.
The diff coverage is 61.11%.

Impacted Files Coverage Δ
src/awkward/_v2/contents/content.py 81.89% <ø> (+0.31%) ⬆️
src/awkward/_v2/contents/indexedarray.py 60.64% <ø> (-0.10%) ⬇️
src/awkward/_v2/contents/indexedoptionarray.py 85.40% <ø> (+0.15%) ⬆️
src/awkward/_v2/contents/listarray.py 87.95% <ø> (+0.21%) ⬆️
src/awkward/_v2/contents/regulararray.py 82.85% <ø> (+0.18%) ⬆️
...c/awkward/_v2/operations/describe/ak_parameters.py 41.66% <22.22%> (-38.34%) ⬇️
src/awkward/_v2/_util.py 83.79% <100.00%> (+1.55%) ⬆️
src/awkward/_v2/contents/numpyarray.py 89.74% <100.00%> (+0.02%) ⬆️
src/awkward/_v2/contents/recordarray.py 80.86% <100.00%> (+1.12%) ⬆️
src/awkward/_v2/contents/unionarray.py 84.08% <100.00%> (+0.07%) ⬆️
... and 144 more

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

We talked about these things on Slack, but for posterity:

  • The new merge_equal flag for merge_parameters is good, as it bring the use of this function in line with one of the same name in v1. The other use of this function is in Arrow conversions, which has the different merging behavior, and that's why you need a flag.
  • A lot of the changes in the tests are replacing XYZ.parameters with ak._v2.operations.describe.parameters(XYZ), which is fine. The behavior defined by the tests has not changed.

@jpivarski jpivarski enabled auto-merge (squash) January 27, 2022 20:13
@jpivarski jpivarski merged commit 22b3aaf into main Jan 27, 2022
@jpivarski jpivarski deleted the ioanaif/ak.parameters branch January 27, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants