style: update to first non-pre-release black! #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
jpivarski
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
I've always thought that ** should be an exception to the "spaces around binary operators" rule.
All the other changes are more compact and look more readable, too. This is definitely an improvement.
It touches a lot of files, 35, but only 8 of them are not tests. Tests generally don't overlap people's active work—I don't think that merging this would be disruptive.
|
(I think it's increasing test coverage because the more compact representation means fewer lines of code to test!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exponent change is really nice, it also seems a bit more compact for really long asserts and if's.