-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Awkward --> C++ with Cling. #1300
Merged
jpivarski
merged 21 commits into
main
from
jpivarski/awkward-to-cpp-converter-with-cling
Feb 23, 2022
Merged
Implement Awkward --> C++ with Cling. #1300
jpivarski
merged 21 commits into
main
from
jpivarski/awkward-to-cpp-converter-with-cling
Feb 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the Awkward → RDataFrame step in ianna/awkward-to-rdf, but it won't include any RDataFrame-specific stuff (just Cling). @ianna will be able to use this, so it's a blocker for the to-RDF step, but it's not a blocker for the from-RDF step.
Things to do:
Lookup
class andtolookup
function(s) from the Numba implementation to use them here. There's nothing Numba-specific about them, but those functions are spread throughout all the Numba Content Types as classmethods. Probably the right way to do it is to make a suite of LookupTypes that is independent of both Numba and C++, then the Numba Content Types would be subclasses. It's relevant because the LookupTypes are, in part, defined by thecls.STARTS
,cls.STOPS
,cls.CONTENT
constants that define the order of the lookup table, and we want to keep that code together as a unit.ak::ArrayView
withstart
,stop
,which_array
, andarray_ptrs
(32 bytes). All of the Awkward data will be subclasses of this, but they will add no member data and only the subclasses would ever get instantiated. (Find out if this means there will be an unwanted vtable or not.)ak::RecordView
, which doesn't derive from the above (sequences and scalars are distinct).ak::List<T>
, from which concrete types will derive. IfT
is a primitive type, the concrete type will either be anotherak::List<T>
or aROOT::RVec<T>
, depending on a user configuation. This question prescribes the set of methods expected on an immutable sequence. Include a placeholder for ato_RVec() const
method.ak::RecordView
.std::variant
, so maybe).That should do it. In the end, it should have a clean API for @ianna to use.