Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: ak.strings_astype #1301

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Feb 21, 2022

No description provided.

@ioanaif ioanaif marked this pull request as draft February 21, 2022 15:10
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1301 (63587ae) into main (8e68200) will decrease coverage by 0.19%.
The diff coverage is 78.32%.

Impacted Files Coverage Δ
src/awkward/_v2/_connect/numba/arrayview.py 96.76% <ø> (ø)
src/awkward/_v2/_connect/numba/layout.py 84.34% <ø> (ø)
src/awkward/_v2/_prettyprint.py 63.79% <0.00%> (ø)
src/awkward/_v2/_slicing.py 84.43% <ø> (ø)
src/awkward/_v2/contents/__init__.py 100.00% <ø> (ø)
src/awkward/_v2/forms/__init__.py 100.00% <ø> (ø)
src/awkward/_v2/identifier.py 55.69% <ø> (ø)
.../awkward/_v2/operations/convert/ak_from_buffers.py 85.71% <ø> (ø)
src/awkward/_v2/operations/convert/ak_from_cupy.py 25.00% <0.00%> (-50.00%) ⬇️
src/awkward/_v2/operations/convert/ak_from_iter.py 92.30% <ø> (ø)
... and 175 more

@ioanaif ioanaif marked this pull request as ready for review February 24, 2022 15:41
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@jpivarski jpivarski merged commit 53e9e12 into main Feb 24, 2022
@jpivarski jpivarski deleted the ioanaif/ak.strings_astype branch February 24, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants