Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement all of the getitem cases for NumpyArray/ListArray in Numba. #15

Merged
merged 36 commits into from
Oct 10, 2019
Merged

Implement all of the getitem cases for NumpyArray/ListArray in Numba. #15

merged 36 commits into from
Oct 10, 2019

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski
Get started on this PR.
e79939b
@jpivarski
Bring basic getitems of ListOffsetArray up to speed.
ff8f629
@jpivarski
Removed underscores from _numba.util functions.
1abf837
@jpivarski
Infrastructure for ListOffsetArray.getitem(tuple).
7cbc00b
@jpivarski
ListOffsetArray and ListArray's Numba implementations are synchronized.
0b5f315
@jpivarski
Pass other getitem types through the tuple-handler.
9dcf700
@jpivarski
A 64-bit ListArray-NumpyArray advanced array index works.
1a03600
@jpivarski
Identities that have been tested are correct, but some id assignments…
f1da14f 
… are wrong.
@jpivarski
Fixing wrong .id assignments.
863e16d
@jpivarski
Now all the .id assignments should be correct.
ba61aa5
@jpivarski
Cleaned up all TODOs.
ffb2b8f
@jpivarski
Transfer to laptop.
2ec6377
@jpivarski
Use arraydecl to type NumpyArray slices.
bb64e21
@jpivarski
Regularize NumpyArray's slice, just like any other.
c39c050
@jpivarski
Slicing 2-dimensional NumpyArray.
fd60d1e
@jpivarski
test_current() is the platform for developing NumpyArray.getitem_next.
6ac1788
@jpivarski
[skip ci] in progress.
1f24f97
@jpivarski
Fancy indexes pass from ListArray to NumpyArray in Numba.
6db10b8
@jpivarski
Try to fix 32-bit error.
51b70f5
@jpivarski
ListArray.getitem_next(int) works.
5dd1b0f
@jpivarski
[skip ci] in progress.
f522bc2
@jpivarski
[skip ci] fixed a carry-issue in type, but there's badly formed LLVM IR.
332a5c0
@jpivarski
ListArray32/64 and ListOffsetArray32/64 are all at the same level: ge…
be5b501 
…titem_next(int*) works.
@jpivarski
Probably fixed 32-bit issue.
429b951
@jpivarski
Try the test without negative-correction on 32-bit.
fa03bf6
@jpivarski
More diagnostics for 32-bit.
10e6f0f
@jpivarski
Yet more diagnostics for 32-bit.
f48e4b4
@jpivarski
Yet yet more diagnostics for 32-bit.
61bd975
@jpivarski
Replace 'zext' with 'sext'.
bb2dae0
@jpivarski
Cleaned up all debugging code.
8436f83
@jpivarski jpivarski changed the title [WIP] Implement all of the getitem cases for NumpyArray/ListArray in Numba. Implement all of the getitem cases for NumpyArray/ListArray in Numba. Oct 10, 2019
@jpivarski jpivarski merged commit b78e95b into master Oct 10, 2019
@jpivarski jpivarski deleted the feature/finish-up-getitem-in-numba branch October 10, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpivarski