Growable Buffer header

[ManasviGoyal]

New header-only implementation of Growable Buffer using panels. Contains the following :-

• GrowableBuffer.h
• Unit Tests for GrowableBuffer
• Documentation of GrowableBuffer.h

[codecov]

Codecov Report

Merging #1535 (502a84c) into main (78a6535) will decrease coverage by 0.11%.
The diff coverage is 57.93%.

Impacted Files	Coverage Δ
src/awkward/_v2/highlevel.py	70.77% <57.60%> (-2.76%)	⬇️
src/awkward/_v2/_connect/numba/arrayview.py	96.76% <100.00%> (ø)

[jpivarski]

Great! The location of this file will move and it the class will get new methods, but this is a good checkpoint.

To get the tests to pass, merge with main. @ioanaif's #1533 fixes the pre-commit issues that you see. Once it does pass tests, you can squash-and-merge it yourself.

[ManasviGoyal]

Great! The location of this file will move and it the class will get new methods, but this is a good checkpoint.

To get the tests to pass, merge with main. @ioanaif's #1533 fixes the pre-commit issues that you see. Once it does pass tests, you can squash-and-merge it yourself.

Sure. Thanks. I have added the function that is needed for use in Array Builder. So, it should be able to work with Array Builders and the new Layout Builder. New methods can be added as and when they are needed.

[jpivarski]

At some point, we should be able to remove the old GrowableBuffer, too.

Is that currently dead code? (I.e. if you just remove the old GrowableBuffer, can it compile?) When it is possible to remove, let's do that right away so that we don't end up with a name conflict somehow.

Fortunately, GrowableBuffer does not have a pybind11 interface, so there won't be anything in the src/python directory to dismantle.

[ianna]

Please, see my comment about accessing private members from a static function. Thanks.

[ianna]

Ok, my compiler does not like that the static function accesses the private members. Here is an alternative implementation.

[ianna]

This looks good! Thanks. Please, merge it when the tests pass.

[jpivarski]

@all-contributors please add @ManasviGoyal for code

[allcontributors]

@jpivarski

I've put up a pull request to add @ManasviGoyal! 🎉